Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32682
Change subject: mb/samsung/lumpy: Fix MRC raminit ......................................................................
mb/samsung/lumpy: Fix MRC raminit
Fix onboard SPD config placement for mrc.bin and remove outdated comment.
ChangeId dedcc78ff44f4eb7c227ade84ee35e007f183a89 removed support for 0xf0 SPD address, but the spd_data index wasn't adjusted.
ChangeId If1b94e050d7e8d0dbd349c0415a182730aa5fa90 missed that too while fixing the channel order for native raminit.
Change-Id: If1910e82a4bd178c2a6c2991c91e09782122888e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/samsung/lumpy/romstage.c 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/32682/1
diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c index 1080689..a77149d 100644 --- a/src/mainboard/samsung/lumpy/romstage.c +++ b/src/mainboard/samsung/lumpy/romstage.c @@ -148,7 +148,6 @@ die("SPD data not found."); if (spd_file_len < (spd_index + 1) * 256) die("Missing SPD data."); - // leave onboard dimm address at f0, and copy spd data there. return spd_data[spd_index]; }
@@ -198,8 +197,7 @@ }, }; *pei_data = pei_data_template; - // leave onboard dimm address at f0, and copy spd data there. - memcpy(pei_data->spd_data[0], locate_spd(), 256); + memcpy(pei_data->spd_data[2], locate_spd(), 256); }
const struct southbridge_usb_port mainboard_usb_ports[] = {