Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35241 )
Change subject: mb/google/drallion: Dynamicly disable memory channel
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35241/6/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/35241/6/src/mainboard/google/dralli...
PS6, Line 291: * 0:Enable both DIMMs, 3:Disable both DIMMs
Please look at the allowed comment styles in the coding style document. Add space after the colons.
/* Disable memory …
0: Enable both DIMMs, 3: Disable both DIMMs */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35241
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5f53f0ba3bd432fbcb7513d2a8aa49d42f7a23e
Gerrit-Change-Number: 35241
Gerrit-PatchSet: 6
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Sep 2019 12:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment