Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35607 )
Change subject: vboot: verify the GBB_HWID as part of the build steps
......................................................................
Patch Set 7:
(2 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/35607/6/src/security/vboot/check_hw...
File src/security/vboot/check_hwid.sh:
https://review.coreboot.org/c/coreboot/+/35607/6/src/security/vboot/check_hw...
PS6, Line 36: crc32
crc32 is not installed by default in the chroot, that will need to change to get this change through […]
Weird. I don't remember installing it, though.
It's possible that this shell script is going to be replaced with some python code (using zlib) instead.
https://review.coreboot.org/c/coreboot/+/35607/6/src/security/vboot/check_hw...
PS6, Line 50: ${HWID}
Add quotes around the HWIDs
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35607
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfef1b118dca0927ef09674351f26cb2a5ad2171
Gerrit-Change-Number: 35607
Gerrit-PatchSet: 7
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Sep 2019 16:29:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment