Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h File src/include/edid.h:
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h@109 PS10, Line 109: int row_byte_alignment);
Yes, you can remove all of those as long as you pass the correct row_alignment instead.
Anything to do here? Could it be done in a follow-up?
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... PS7, Line 49: struct edid;
Should include <edid. […]
Done
https://review.coreboot.org/c/coreboot/+/39006/8/src/mainboard/google/daisy/... File src/mainboard/google/daisy/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39006/8/src/mainboard/google/daisy/... PS8, Line 34: #include <framebuffer_info.h>
Please sort new headers in alphabetically, at least in files that are already doing that.
Done