[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Enable FSP to use coreboot stack for cometlake

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34130 )

Change subject: soc/intel/cannonlake: Enable FSP to use coreboot stack for cometlake
......................................................................

Patch Set 5:
> Patch Set 5:
> > However, I believe this feature was moved in to the CoffeeLake FSP even though it technically only implements FSP spec v2.0. Accordingly, I agree that this should be mentioned in the CoffeeLake FSP integration guide if it is not already.
>
> Please also publish the integration guide, as the external specification guide doesn't specify the exact HOB heap size requirements.

I'm willing to merge the patch as is, even before these items are published if a bug is filed in the coreboot bug system for the updates mentioned above.  Before that's done to track the requested updates, I'm hesitant to merge it.

https://ticket.coreboot.org/projects/coreboot