[coreboot-gerrit] Change in ...coreboot[master]: acpi: Add SPMI table

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33487 )

Change subject: acpi: Add SPMI table
......................................................................

Patch Set 3:

(1 comment)

Mention SPMI spec link https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/... will be better.

https://review.coreboot.org/#/c/33487/3/src/arch/x86/acpi.c 
File src/arch/x86/acpi.c:

https://review.coreboot.org/#/c/33487/3/src/arch/x86/acpi.c@812 
PS3, Line 812: spmi->interrupt_type |= 1
Instead of |=, just use "=" directly? Instead of using value 1 and 2 directly, may be replace with 1 <<0 and 1<<1 or some meaningful definition in acpi.h to make it more clear?

enum acpi_ipmi_interrupt_type {
    IPMI_INTERRUPT_GPE = 1,
    IPMI_INTERRUPT_APIC = 2
};