Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )
Change subject: vboot: refactor OPROM code ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig@180 PS7, Line 180: and any other native display initialization code is not run This doesn't seem to reflect the code on older x86 platforms. AFAIUI, the first native graphics init for Intel was always run and in case of failure, the option ROM was run conditionally. I don't know if the NGI was run unconditionally by accident, but we have still a lot code that reflects that. I guess somebody should check at least all the Intel platforms that select this, if they comply with this description.
Some NGI instances were replaced with libgfxinit by now. But I'm rather sure that we maintained the old -- probably wrong -- behavior.
https://review.coreboot.org/#/c/32262/7/src/security/vboot/vboot_handoff.c File src/security/vboot/vboot_handoff.c:
https://review.coreboot.org/#/c/32262/7/src/security/vboot/vboot_handoff.c@8... PS7, Line 84: VBSD_OPROM_LOADED out of curiosity, I assume `VBSD_OPROM_LOADED` implies more than what the name says? it's not that we always have an oprom to load.