Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31608 )
Change subject: prog_loader: Associate TS_END_ROMSTAGE timestamp with postcar if exist ......................................................................
Patch Set 1:
(2 comments)
Subrata, please wait for other reviewers to comment before reacting to my comments.
https://review.coreboot.org/#/c/31608/1/src/arch/x86/postcar_loader.c File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/#/c/31608/1/src/arch/x86/postcar_loader.c@164 PS1, Line 164: timestamp_add_now(TS_END_ROMSTAGE); I might move this just before prog_run() line below. There this timestamp would remain almost unchanged in comparison to previous build.
Then again, we probably want to be consistent with whether time spent loading or decompressing stage N+1 is included in between start..end of stage N.
https://review.coreboot.org/#/c/31608/1/src/lib/prog_loaders.c File src/lib/prog_loaders.c:
https://review.coreboot.org/#/c/31608/1/src/lib/prog_loaders.c@132 PS1, Line 132: if (!IS_ENABLED(CONFIG_ARCH_POSTCAR_X86_32)) Maybe:
if (!ENV_POSTCAR)