Subrata, please wait for other reviewers to comment before reacting to my comments.
2 comments:
File src/arch/x86/postcar_loader.c:
Patch Set #1, Line 164: timestamp_add_now(TS_END_ROMSTAGE);
I might move this just before prog_run() line below. There this timestamp would remain almost unchanged in comparison to previous build.
Then again, we probably want to be consistent with whether time spent loading or decompressing stage N+1 is included in between start..end of stage N.
Patch Set #1, Line 132: if (!IS_ENABLED(CONFIG_ARCH_POSTCAR_X86_32))
Maybe:
if (!ENV_POSTCAR)
To view, visit change 31608. To unsubscribe, or for help writing mail filters, visit settings.