Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41384 )
Change subject: device/pci_device: Add notion of "hidden" PCI devices
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c@122...
PS7, Line 1223: * ID as if there were no device there (0xffffffff).
Sure, SGTM. […]
I would prefer to _not_ treat hidden devices as PCI devices.
However, if there is still a way to access their config space and coreboot
has to access it, the mechanism here seems reasonable. Is that the case
for the PMC? I just assumed because you metioned the readability of the
config space.
If there is no need to treat it as a PCI device any more, I would suggest
a "generic" device instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16c2d3e1d1433343e63dfc16856cff69cd815e2a
Gerrit-Change-Number: 41384
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 May 2020 17:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment