[coreboot-gerrit] Change in ...coreboot[master]: vboot: refactor OPROM code

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )

Change subject: vboot: refactor OPROM code
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig 
File src/security/vboot/Kconfig:

https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig@180 
PS7, Line 180: and any other native display initialization code is not run
> The second sentence describes how things are supposed to work if the platform sets this flag. […]

Sorry, I forgot to mention, I had Haswell in mind.
Which selects it. Maybe I overestimated the problem
and that's the only one.

https://review.coreboot.org/#/c/32262/7/src/security/vboot/vboot_handoff.c 
File src/security/vboot/vboot_handoff.c:

https://review.coreboot.org/#/c/32262/7/src/security/vboot/vboot_handoff.c@8... 
PS7, Line 84: VBSD_OPROM_LOADED
> Yes, the whole "oprom" name isn't really accurate anymore, it's a general "we have enabled the displ […]

Ack