Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 96: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34603/96/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/34603/96/src/mainboard/asus/h110m-e... PS96, Line 13: 18 the Interrupt Select (INTSEL) field is read-only and should be set to 00h in all DW1 registers. An exception is when we set host owership (bit 4 - https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...) to driver mode