Attention is currently required from: Christian Walter, Sean Rhodes.
Angel Pons has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/74743?usp=email )
Change subject: mb/starlabs/starbook: Put options in CFR cbtable ......................................................................
Patch Set 35: Code-Review+1
(1 comment)
File src/mainboard/starlabs/starbook/cfr.c:
https://review.coreboot.org/c/coreboot/+/74743/comment/eacb6633_465f7ac6?usp... : PS35, Line 380: void lb_board(struct lb_header *header) : { : char *current = (char *)lb_new_record(header); : struct lb_cfr *cfr_root = (struct lb_cfr *)current; : : cfr_write_setup_menu(cfr_root, sm_root); : } :
should be: […]
```suggestion void mb_cfr_setup_menu(struct lb_cfr *cfr_root) { cfr_write_setup_menu(cfr_root, sm_root); }
``` I think something broke code blocks / suggestions in Gerrit, at least for me: newlines disappear for no reason when saving.