[coreboot-gerrit] Change in ...coreboot[master]: (drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 )

Change subject: (drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support
......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/#/c/29662/9/src/soc/intel/braswell/bootblock/boo... 
File src/soc/intel/braswell/bootblock/bootblock.c:

https://review.coreboot.org/#/c/29662/9/src/soc/intel/braswell/bootblock/boo... 
PS9, Line 76:
> This code is not used in latest patch.

See how it is done in src/cpu/intel/car/non-evict/cache_as_ram.S

https://review.coreboot.org/#/c/29662/11/src/soc/intel/braswell/bootblock/ca... 
File src/soc/intel/braswell/bootblock/cache_as_ram.S:

https://review.coreboot.org/#/c/29662/11/src/soc/intel/braswell/bootblock/ca... 
PS11, Line 12: either version 2 of the License, or
             :  * (at your option) any later version.
Have you asked the previous copyright owners if they want to change the license?