Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32905 )
Change subject: RFC: smbios: allow setting BIOS-version string from VPD variable ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/32905/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32905/3//COMMIT_MSG@7 PS3, Line 7: BIOS-version No hyphon: BIOS version
https://review.coreboot.org/#/c/32905/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32905/3/src/arch/x86/smbios.c@353 PS3, Line 353: #if CONFIG(VPD) Can this be done in C and not the preprocessor?
https://review.coreboot.org/#/c/32905/3/src/arch/x86/smbios.c@354 PS3, Line 354: /* size is unused for now */ What does this comment mean?