[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/skyrim: Hide unused GPP port

[Martin Roth (Code Review)]

Attention is currently required from: Martin L Roth, Jason Nien, Eric Lai, Karthik Ramasubramanian, Felix Held.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73862 )

Change subject: mb/google/skyrim: Hide unused GPP port
......................................................................

Patch Set 1:

(1 comment)

File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/73862/comment/212e37d1_99bf310d 
PS1, Line 110: 		device ref gpp_bridge_3 hidden end
> Interesting for AMD here. […]

I don't know what you mean by 'overlap'.

Skyrim uses 4 lanes on 3 links, so we only have 3 PCIe bridges used.  The 4th bridge here would be used if we had 4 x1 GPP ports. Since we don't use that 4th bridge, it's not enabled in the port_descriptors.c file, this device shows up as a leftover device in the devicetree unless we hide it.  Even if it's marked as 'off' it will show up as left over because coreboot can't actually see the bridge unless it's enabled in port_descriptors.c.