Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36263 )
Change subject: [TESTME]soc/intel/braswell: Attempt to skip FSP-T
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Wow, very nice.
https://review.coreboot.org/c/coreboot/+/36263/1/src/soc/intel/braswell/boot...
File src/soc/intel/braswell/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/36263/1/src/soc/intel/braswell/boot...
PS1, Line 198: normally creates at the top of the CAR region */
I think non-concise comments are preferred outside of code blocks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15edf479b09bf9a87afb9ab27e09d4360d21b9ff
Gerrit-Change-Number: 36263
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Oct 2019 16:45:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment