Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47232 )
Change subject: soc/intel/jasperlake: Update reserved GPIO names in gpio_soc_defs.h
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47232/2/src/soc/intel/jasperlake/gp...
File src/soc/intel/jasperlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/47232/2/src/soc/intel/jasperlake/gp...
PS2, Line 48: LOOPNK
Is it supposed to be LOOPBK? i.e. […]
Ack
https://review.coreboot.org/c/coreboot/+/47232/2/src/soc/intel/jasperlake/gp...
PS2, Line 132: GPIO_L_BKLTEN
nit: If you use GPIO_COM4_START and GPIO_COM4_END and similar other macros in this table, then you w […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47232
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8326b7181d47a177261656f51602638d8ce80fbb
Gerrit-Change-Number: 47232
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Nov 2020 03:30:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment