build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28358 )
Change subject: intel/fsp2_0: Add FSP_NXT shared stack feature support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/28358/1/src/drivers/intel/fsp2_0/memory_init... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/#/c/28358/1/src/drivers/intel/fsp2_0/memory_init... PS1, Line 173: if (!IS_ENABLED(CONFIG_PLATFORM_USES_FSP_NXT)) that open brace { should be on the previous line
https://review.coreboot.org/#/c/28358/1/src/drivers/intel/fsp2_0/memory_init... PS1, Line 178: * FSPM_UPD passed here is populated with default values provided by line over 80 characters
https://review.coreboot.org/#/c/28358/1/src/drivers/intel/fsp2_0/memory_init... PS1, Line 179: * the blob itself. We let FSPM use top of CAR region of the size it line over 80 characters