Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35167 )
Change subject: soc/skl/vr_config: Add VR config for SKL-S/H/U/Y
......................................................................
Patch Set 19:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/35167/2/src/soc/intel/skylake/vr_co...
File src/soc/intel/skylake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/35167/2/src/soc/intel/skylake/vr_co...
PS2, Line 176: else if (tdp >= 45)
: icc_max[VR_IA_CORE] = VR_CFG_AMP(70);
SKL-H values appear on a different document: #332986 […]
Thanks for the help
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35167
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e517d8230c251e0cd4b1d4f1b9292c3df80cb19
Gerrit-Change-Number: 35167
Gerrit-PatchSet: 19
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Oct 2019 13:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment