Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38187 )
Change subject: console/post: Split parts to arch/
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38187/4/src/console/post.c
File src/console/post.c:
https://review.coreboot.org/c/coreboot/+/38187/4/src/console/post.c@36
PS4, Line 36: mainboard_post(value);
I wonder: shouldn't this be inside the if(!CONFIG(NO_POST)) ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I010af3f645c0be38dd856657874c36103aebbdc2
Gerrit-Change-Number: 38187
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jan 2020 23:55:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment