Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45786 )
Change subject: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45786/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45786/3//COMMIT_MSG@7
PS3, Line 7: include/acpi/acpi.h: Add ACPI_DSDT_REV_1 macro
Would you please mention that you touch the two mianboards in this commit as well? Or even better: Split it into two commits?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45786
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie044f786e5deae3a1317091de67dc03c74531bfb
Gerrit-Change-Number: 45786
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 13:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment