29 Jan
2020
29 Jan
'20
5:47 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38623 )
Change subject: hatch/mushu: Fix FPMCU pwr/rst gpio handling ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38623/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/hatch/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38623/2/src/mainboard/google/hatch/... PS2, Line 25: ramstage-y += ramstage.c
Sure, but then future changes always incur a delete and add in git. […]
No big deal :) I don't think there's a consistent "style" there.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12dc0c3bead7672e2d3207771212efb0d246973a
Gerrit-Change-Number: 38623
Gerrit-PatchSet: 4
Gerrit-Owner: Craig Hesling hesling@chromium.org
Gerrit-Reviewer: Bob Moragues moragues@chromium.org
Gerrit-Reviewer: Craig Hesling hesling@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 Jan 2020 17:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Craig Hesling hesling@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment