HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33799 )
Change subject: src/lib/hexdump: Use size_t for length
......................................................................
Patch Set 6:
(2 comments)
Thank you.
https://review.coreboot.org/c/coreboot/+/33799/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33799/6//COMMIT_MSG@7
PS6, Line 7: length
"indices" might be more accurate here than length
Done
https://review.coreboot.org/c/coreboot/+/33799/6/src/lib/hexdump.c
File src/lib/hexdump.c:
https://review.coreboot.org/c/coreboot/+/33799/6/src/lib/hexdump.c@67
PS6, Line 67: int
I'd use size_t here as well
Why?
it is just a counter
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29a7ae8c499bb1e8ab7c8741b2dfb7663d82a362
Gerrit-Change-Number: 33799
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 13 Jul 2019 05:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment