Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39631 )
Change subject: nb/intel/sandybridge: Use loops on DMI register groups
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39631/3/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/early_dmi.c:
https://review.coreboot.org/c/coreboot/+/39631/3/src/northbridge/intel/sandy...
PS3, Line 24: 1 << 31
Yes, I probably have a poisoned copy... I'll re-check.
Looks like the real culprit is made out of flesh and bones, and is typing this very reply.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebf40b2a5b37ed9060a6660840ea6cdff7eb3fc3
Gerrit-Change-Number: 39631
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Mar 2020 21:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment