Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31340 )
Change subject: cpu/intel/common: Extend FSB detection to cover TSC
......................................................................
Patch Set 2:
The error below is hit.
```
CC smm/cpu/intel/common/fsb.o
src/cpu/intel/common/fsb.c: In function 'get_ia32_fsb':
src/cpu/intel/common/fsb.c:72:5: error: 'fsb' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (*fsb > 0)
^
src/cpu/intel/common/fsb.c:79:11: note: 'fsb' was declared here
int ret, fsb, ratio;
^~~
cc1: all warnings being treated as errors
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7f1815b3fac7a610f7203720d526eac152a1648
Gerrit-Change-Number: 31340
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Jun 2019 14:24:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment