Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36564 )
Change subject: [TESTONLY]cpu/intel/socket_mPGA604: Run romstage from CAR
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36564/2/src/cpu/intel/socket_mPGA60...
File src/cpu/intel/socket_mPGA604/Kconfig:
https://review.coreboot.org/c/coreboot/+/36564/2/src/cpu/intel/socket_mPGA60...
PS2, Line 29: 0xffef0000
any reason why?
You suggested value below 1 << 28, bottom 64 MiB? We want to stay above TOLM but need to avoid some of FWH RW bank registers that extend below ROM size.
I was supposed to put 0xfef00000 here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c35d09b87b545944a4465ff695953d1e8a811e4
Gerrit-Change-Number: 36564
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 02 Nov 2019 22:42:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment