Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )
Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf...
File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf...
PS5, Line 105: default 5
Maybe move these two parameter to device tree?
No, let the CPU/SoC code fill them in by overriding the weak functions instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46119
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Gerrit-Change-Number: 46119
Gerrit-PatchSet: 5
Gerrit-Owner: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 09:25:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-MessageType: comment