Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45407 )
Change subject: region_file_update_data: Change API to accept array of structs ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45407/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45407/4//COMMIT_MSG@9 PS4, Line 9: Update region_file_update_data to accept mutliple data buffers. This will have to be updated since you have a new function now and region_file_update_data still accepts the same parameters.
https://review.coreboot.org/c/coreboot/+/45407/4/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/45407/4/src/drivers/mrc_cache/mrc_c... PS4, Line 423: Unrelated change?
https://review.coreboot.org/c/coreboot/+/45407/4/src/lib/region_file.c File src/lib/region_file.c:
https://review.coreboot.org/c/coreboot/+/45407/4/src/lib/region_file.c@479 PS4, Line 479: return (region_file_update_data_arr(f, &entry, 1) < 0) This can just be: return region_file_update_data_arr(f, &entry, 1);
https://review.coreboot.org/c/coreboot/+/45407/4/src/lib/region_file.c@480 PS4, Line 480: nit: blank line not required.