[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add chipset devicetree

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44038 )

Change subject: soc/intel/tigerlake: Add chipset devicetree
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44038/3/src/soc/intel/tigerlake/Kco... 
File src/soc/intel/tigerlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/44038/3/src/soc/intel/tigerlake/Kco... 
PS3, Line 95:
> checked using "make menuconfig": […]

right, but that doesn't show what selected it.

it gets selected by default as a consequence of selecting TIGERLAKE.
my suggestion is that since this device tree requires DRIVERS_INTEL_WIFI,
we should explicitly select it instead of relying
on "default y" for PCIEXP_PLUGIN_SUPPORT.

the dependency graph looks something like this:

src/mainboard/google/volteer/Kconfig:
   select SOC_INTEL_TIGERLAKE

soc/intel/tigerlake/Kconfig:
 if SOC_INTEL_TIGERLAKE
   select ARCH_BOOTBLOCK_X86_32

arch/x86/Kconfig:
 config ARCH_BOOTBLOCK_X86_32
   select ARCH_X86
 config ARCH_X86
   select PCI

device/Kconfig:
 if PCI
   config PCIEXP_PLUGIN_SUPPORT
     default y

drivers/intel/wifi/Kconfig:
   config DRIVERS_INTEL_WIFI
     default y if PCIEXP_PLUGIN_SUPPORT