Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35313 )
Change subject: nb/amd/pi/00730F01: enable ACS and AER for PCIe ports
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35313/7/src/northbridge/amd/pi/0073...
File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/35313/7/src/northbridge/amd/pi/0073...
PS7, Line 794: value |= (BIT(5) | BIT(6));
But you write `AER (bit 5)` explicitly. […]
I missed the comment... Looked at BKDG that had these bits undocumented and prematurely answered without noticing my comment... Some of BKDgs have at least AER documented.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10a8eff0ba37196692f9db6519e498fe535ecd15
Gerrit-Change-Number: 35313
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 17 Feb 2020 11:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment