[coreboot-gerrit] Change in coreboot[master]: Revert "lib/fmap: Disable pre-RAM cache for FSP 1.0"

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37084 )

Change subject: Revert "lib/fmap: Disable pre-RAM cache for FSP 1.0"
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> > > Patch Set 2: Code-Review-2
> > > > Patch Set 2:
> > > > > Patch Set 1:
> > > > >
> > > > > What about rockchip? Julius added it on purpose I guess?
> > > >
> > > > Then this gets -2 for the time being. I only read the title before hitting revert button :)
> > >
> > > And obviously SOC_INTEL_GLK wants it too...
> >
> > Both GLK and rk3288 do it because of code size constraints.
>
> We can fix GLK. Which stage failed to link with this?

FYI: I just built meep w/o selecting no_fmap_cache:

$ ./util/abuild/abuild -c 48 -p none -v -t GOOGLE_MEEP            
Building config GOOGLE_MEEP_CROS
Building GOOGLE_MEEP_CROS
    GOOGLE_MEEP (default configuration)
  Compiling GOOGLE_MEEP image on 48 cpus in parallel...                        
GOOGLE_MEEP_CROS built successfully. (took 6s)                                 
All 1 tested configurations passed.

$ grep FMAP_CACHE coreboot-builds/GOOGLE_MEEP_CROS/config.h
#define CONFIG_NO_FMAP_CACHE 0