Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40579 )
Change subject: vboot: Add permission check for kernel space
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40579/6/src/security/vboot/secdata_...
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/40579/6/src/security/vboot/secdata_...
PS6, Line 86: "TPM: invalid secdata_kernel permissions\n");
This should fit in one line.
I don't think it does? As long as files aren't globally adjusted to 96 characters, we should stick to 80 when the rest of the file does too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40579
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6d487940f39865cadc0ca9d5de6e055ad3e017d
Gerrit-Change-Number: 40579
Gerrit-PatchSet: 7
Gerrit-Owner: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Apr 2020 21:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment