yongqiang niu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )
Change subject: mediatek/mt8183: Add display driver
......................................................................
Patch Set 14:
Patch Set 13:
A lot of this seems duplicated from MT8173 code. Can you factor out the common parts?
there are 18 functions in 8183 ddp.c, but only 1(color_start) of them is same with 8173, the duplicate rate is 5.5%
there are 17 struct or enum define in 8183 ddp.h, but only 2 (disp_color_regs, OVL_INPUT_FORMAT) of them is same with 8173, the duplicate rate is 11.7%
i suppose the duplicate rate is too low, and no common them, please double confirm
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4aecc58d081f14f5d136b9ff8e813e6f40f78eb
Gerrit-Change-Number: 31478
Gerrit-PatchSet: 14
Gerrit-Owner: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Reviewer: Chun-ta Lin
itspeter@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yongqiang Niu
yongqiang.niu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 12 Jun 2019 09:49:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment