Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36550 )
Change subject: soc/intel/tigerlake/bootblock: Do initial SoC commit till bootblock ......................................................................
Patch Set 7:
(2 comments)
Patch Set 7:
(2 comments)
It would be nice to have the following documented in the commit messages of the copy-paste commits: For each added function or selected Kconfig, if
- the respective function or guarded code was reviewed to be compatible with Tiger Lake or
- if there will be a follow up commit adapting it, also if
- the respective function or guarded code was tested specifically.
https://review.coreboot.org/c/coreboot/+/36550/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36550/7//COMMIT_MSG@23 PS7, Line 23: from an authoritative internal source.
What is this supposed to mean? And why can't you share the document numbers? […]
this string is what i could see in kernel early soc commit msg and thats how kernel community takes non-prq soc changes, hence thought of mentioning here. if objection, we can take this out.
regarding doc number i believe each file has respective doc number mentioned
https://review.coreboot.org/c/coreboot/+/36550/7//COMMIT_MSG@25 PS7, Line 25: The patch has been tested on real hardware."
What does this mean? what would be non-real hardware? Please […]
as i mentioned its copy patch so its not expected to for early few CL's without the mainboard CL. but in a series we have tested on real HW. i guess its better to remove this string as it adds confusion