Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35889 )
Change subject: mainboard/pcengines/apu2/mainboard.c: fill SMBIOS type 16 and 17 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35889/2/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35889/2/src/mainboard/pcengines/apu... PS2, Line 160: static void set_dimm_info(uint8_t *spd, struct dimm_info *dimm) that's not board specific
https://review.coreboot.org/c/coreboot/+/35889/2/src/mainboard/pcengines/apu... PS2, Line 222: mem_info = cbmem_add(CBMEM_ID_MEMINFO, sizeof(*mem_info)); usually added in romstage by DRAM init code