Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44569 )
Change subject: soc/mediatek/mt8192: Do dram fast calibration ......................................................................
Patch Set 12:
(7 comments)
https://review.coreboot.org/c/coreboot/+/44569/11/src/soc/mediatek/mt8192/me... File src/soc/mediatek/mt8192/memory.c:
https://review.coreboot.org/c/coreboot/+/44569/11/src/soc/mediatek/mt8192/me... PS11, Line 20: .
No period for consistency
Ack
https://review.coreboot.org/c/coreboot/+/44569/11/src/soc/mediatek/mt8192/me... PS11, Line 21: (
Align with BIOS_DEBUG
Ack
https://review.coreboot.org/c/coreboot/+/44569/11/src/soc/mediatek/mt8192/me... PS11, Line 57:
Also compare the 'config'? See https://crrev.com/c/2411877.
Ack
https://review.coreboot.org/c/coreboot/+/44569/11/src/soc/mediatek/mt8192/me... PS11, Line 78: :
One space after ":"
Ack
https://review.coreboot.org/c/coreboot/+/44569/11/src/soc/mediatek/mt8192/me... PS11, Line 91: Fast Calibration
Running fast calibration
Ack
https://review.coreboot.org/c/coreboot/+/44569/11/src/soc/mediatek/mt8192/me... PS11, Line 95: /* need to erase the flash data immediately when fast calibration : fail */
/* Erase flash data after fast calibration failed */
Ack
https://review.coreboot.org/c/coreboot/+/44569/11/src/soc/mediatek/mt8192/me... PS11, Line 100: Fast Calibration PASS
Fast calibration passed
Ack