Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38349 )
Change subject: util/pmh7tool: Support OpenBSD ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38349/2/util/pmh7tool/pmh7tool.c File util/pmh7tool/pmh7tool.c:
https://review.coreboot.org/c/coreboot/+/38349/2/util/pmh7tool/pmh7tool.c@19 PS2, Line 19: #if !defined __OpenBSD__ we generally wrap the term we're looking for: #if !defined(__OpenBSD__)
(also in a few more places)
https://review.coreboot.org/c/coreboot/+/38349/2/util/pmh7tool/pmh7tool.c@33 PS2, Line 33: __asm volatile("inb %w1,%0" : "=a" (data) : "d" (port));
I'm not sure how to fix these or should these be fixed at all.
No need to do anything about it. A false positive by our tooling.
https://review.coreboot.org/c/coreboot/+/38349/2/util/pmh7tool/pmh7tool.c@21... PS2, Line 211: #if !defined __OpenBSD__ I'd consider doing #ifdef __OpenBSD__ iopl #else ioperm #endif
because I suspect that other BSDs have the same issue, and IMHO it's slightly more readable without tons of negations.