Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27561 )
Change subject: drivers/i2c/da7219: Add vddio property
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27561/2/src/drivers/i2c/da7219/da7219.c
File src/drivers/i2c/da7219/da7219.c:
https://review.coreboot.org/#/c/27561/2/src/drivers/i2c/da7219/da7219.c@87
PS2, Line 87: acpi_dp_add_integer(dsd, "dlg,vddio", config->vddio);
Shouldn't this be done after ensuring vddio is non-zero:
if (config->vddio)
...
--
To view, visit
https://review.coreboot.org/27561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87ff6e22e2d38e984a8fd7f8434e3f55fd3def24
Gerrit-Change-Number: 27561
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Akshu Agrawal
akshu.agrawal@amd.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Sat, 21 Jul 2018 05:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No