[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/common: Refactor S3 helpers

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31490 )

Change subject: soc/amd/common: Refactor S3 helpers
......................................................................

Patch Set 5:

(1 comment)

I'm fine with the rewrite, subject to what Richard identified.

https://review.coreboot.org/#/c/31490/5/src/soc/amd/common/block/pi/agesawra... 
File src/soc/amd/common/block/pi/agesawrapper.c:

https://review.coreboot.org/#/c/31490/5/src/soc/amd/common/block/pi/agesawra... 
PS5, Line 315: 	Status = OemS3Save(&RtbParams->S3DataBlock);
> Status is supposed to save the return of amd_dispatch, don't use it here. Instead use: […]

I'd be reluctant to rely on AGESA_SUCCESS being 0 like that.  Maybe instead, check Status after amd_dispatch() and if not SUCCESS, print an error and return early.