Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou.
Subrata Banik has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/84999?usp=email )
Change subject: mb/google/nissa/var/rull: add touchpad init config of Synaptics&PIXART
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/rull/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84999/comment/54781cb0_a34f7db1?usp... :
PS4, Line 253: end
i found multiple touchpads submitted by coreboot, and it seems that none of them use FW_config to probe; and we use different i2c addresses, so it doesn't matter even if we don't distinguish them.
that is true but it will create ACPI soft device entry. you can assume something like this, if someone is taking this device and booting to OS then they will see many inactive device entries due to redundant ACPI entries
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84999?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacf09cd46d4a97fb79f91043c84452f76689462f
Gerrit-Change-Number: 84999
Gerrit-PatchSet: 6
Gerrit-Owner: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 05 Nov 2024 09:23:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com