Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44383 )
Change subject: soc/ti/am335x: Fix timer implementation
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44383/5/src/soc/ti/am335x/timer.c
File src/soc/ti/am335x/timer.c:
https://review.coreboot.org/c/coreboot/+/44383/5/src/soc/ti/am335x/timer.c@1...
PS5, Line 10: struct am335x_dmtimer *dmtimer_2 = (struct am335x_dmtimer *)0x48040000;
please use a define or a symbol from the memlayout file to get the address
No need for volatile here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4736b6d3b6e26370be9e8f369fc02285ad519223
Gerrit-Change-Number: 44383
Gerrit-PatchSet: 5
Gerrit-Owner: Sam Lewis
sam.vr.lewis@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Aug 2020 04:53:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment