Attention is currently required from: V Sowmya, Shahina Shaik, Haribalaraman Ramasubramanian, Paul Menzel, Sridhar Siricilla, Balaji Manigandan, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69221 )
Change subject: security/vboot: Fix different size operands in bitwise operation
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Please see Julius' comment in https://chromium-review.googlesource. […]
Thanks, yeah, I still agree with what I said there. If someone wants to change this to make the static analysis shut up about it, we can just change the VB2_CONTEXT flags to be #defined with ULL right now (don't need to wait until we have more than 32 for that). But we shouldn't be adding casts.
PS2:
This isn't necessary and
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifecd5de843bd0229c0cab758d4a641889b4bffd6
Gerrit-Change-Number: 69221
Gerrit-PatchSet: 2
Gerrit-Owner: Shahina Shaik
shahina.shaik@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shahina Shaik
shahina.shaik@intel.corp-partner.google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Shahina Shaik
shahina.shaik@intel.com
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Shahina Shaik
shahina.shaik@intel.corp-partner.google.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 09 Nov 2022 00:42:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment