Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )
Change subject: cpu/x86: Make MP init timeout configurable
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38546/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38546/9//COMMIT_MSG@15
PS9, Line 15: needs to be heuristic
I must miss something here. On a system with only few threads,
why would a smaller timeout be favorable?
I know there are places, even in firmware, for tight timeouts,
e.g. when you want to probe for something optional and still
boot fast or for responsiveness in a UI loop. But why here?
AFAICS, if we time out here, the whole system runs into an
undefined state. So it's not about boot times, is it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38546
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc079fc6aa8641d4ac8d8e726899b6c8d055052e
Gerrit-Change-Number: 38546
Gerrit-PatchSet: 9
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jan 2020 11:57:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment