Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48728 )
Change subject: Add a brief mode for trace output
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/em100/+/48728/2/trace.c
File trace.c:
https://review.coreboot.org/c/em100/+/48728/2/trace.c@313
PS2, Line 313: outbytes
This should not ever be true with trace_brief, right?
That's a good point. I copied this blindly from Duncan's original patch but I might have gotten it wrong (or it was never needed). Let me check the original code again and hopefully remove this if it's not needed.
--
To view, visit
https://review.coreboot.org/c/em100/+/48728
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Icdaa3444bba03be8bf122239fd6da805cf840e52
Gerrit-Change-Number: 48728
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 22 Dec 2020 00:44:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment