Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34992 ) Change subject: soc/intel/common: Make use of clflush in common platform_segment_loaded ...................................................................... Patch Set 2: (3 comments) Move to cpu/x86? I don't think it is Intel specific. https://review.coreboot.org/c/coreboot/+/34992/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/car.c: https://review.coreboot.org/c/coreboot/+/34992/2/src/soc/intel/common/block/... PS2, Line 36: ALIGN_DOWN(size + 4096, 4096) What is this about? https://review.coreboot.org/c/coreboot/+/34992/2/src/soc/intel/common/block/... PS2, Line 37: 64 you can get cacheline size from cpuid. https://review.coreboot.org/c/coreboot/+/34992/2/src/soc/intel/common/block/... PS2, Line 38: clflush Check for cflush in cpuid? -- To view, visit https://review.coreboot.org/c/coreboot/+/34992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I591f21cb4199477af271f0dd6c073e1c11831bfd Gerrit-Change-Number: 34992 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Fri, 08 Nov 2019 22:47:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment