Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 )
Change subject: mb/kontron/bsl6: Add new Skylake COMe module ......................................................................
Patch Set 30:
(4 comments)
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/Kconfig:
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... PS29, Line 21: select DRIVERS_I2C_LM96000
if BOARD_SIEMENS_BOXER26
Done
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... PS29, Line 46: config CBFS_SIZE : hex : default 0x600000
Did I set this? ^^ […]
No, I added this, because a complete (tm) mainboard port should have this IMO.
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/cmos.layout:
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... PS29, Line 54: 5 0 Disable : 5 1 Enable
nit: these can use ID 2 instead
Done
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/gpio.h:
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... PS29, Line 226: PAD_CFG_NF(GPP_I10, NONE, PLTRST, NF1),
Some of the comments are stale (my fault). I wonder if we should remove them all. […]
I also think we should remove the comments, since this way feels wrong, but no idea how to do it better.
I will leave the comments here until we have found a better solution.