build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37737 )
Change subject: [TRY] mb/msi/ms7721: switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37737/1/src/mainboard/msi/ms7721/bo...
File src/mainboard/msi/ms7721/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37737/1/src/mainboard/msi/ms7721/bo...
PS1, Line 26: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x))
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17e09c366ae0c9c99d5c65dd1f00672697a7c709
Gerrit-Change-Number: 37737
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Dec 2019 12:33:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment