HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )
Change subject: sb/{ICH7,NM10,PCH}: Use common watchdog_off function
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/tco.h
File src/southbridge/intel/common/tco.h:
https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/tco.h@1...
PS8, Line 17: #define TCOBASE 0x60
this is ambiguous. […]
Done
https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/tco.h@2...
PS8, Line 21: define TCO1_TIMEOUT (1 << 3)
: #define SECOND_TO_STS (1 << 1)
: #define TCO_TMR_HLT (1 << 11)
Please indent the names to make them visibly distinctive from the […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I704780b6ae7238560dcb72fc027addc1089e0674
Gerrit-Change-Number: 32533
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Guckian
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 04 May 2019 05:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment