17 Apr
2022
17 Apr
'22
12:27 p.m.
Attention is currently required from: Mike Banon, Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Elyes Haouas, Felix Held. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61919 )
Change subject: mb/lenovo/g505s/irq_tables.c: Use ALIGN_UP macro ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2: This change is good. Although the updated code at not-merged-yet CB:58752 (from CB:48427 "AMD good IRQs" patches collection) doesn't have this alignment code, I still vote +1 (seems I no longer have +2, otherwise would have given)
--
To view, visit https://review.coreboot.org/c/coreboot/+/61919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bd5e09f51918fe4c7e954edf54ab4d9bc629fd1
Gerrit-Change-Number: 61919
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Mike Banon mikebdp2@gmail.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 17 Apr 2022 12:27:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment